Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zftp: support encoding for download and upload dataset #1942

Merged
merged 3 commits into from Oct 12, 2022

Conversation

tiantn
Copy link
Contributor

@tiantn tiantn commented Sep 29, 2022

Signed-off-by: Tian Na tiantn@cn.ibm.com

Proposed changes

Release Notes

Milestone:

Changelog:

Types of changes

What types of changes does your code introduce to Zowe Explorer?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updates to Documentation or Tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • PR title follows Conventional Commits Guidelines
  • PR Description is included
  • gif or screenshot is included if visual changes are made
  • yarn workspace vscode-extension-for-zowe vscode:prepublish has been executed
  • All checks have passed (DCO, Jenkins and Code Coverage)
  • I have added unit test and it is passing
  • I have added integration test and it is passing
  • There is coverage for the code that I have added
  • I have tested it manually and there are no regressions found
  • I have added necessary documentation (if appropriate)
  • Any PR dependencies have been merged and published (if appropriate)

Further comments

Signed-off-by: Tian Na <tiantn@cn.ibm.com>
Signed-off-by: Tian Na <tiantn@cn.ibm.com>
@tiantn
Copy link
Contributor Author

tiantn commented Sep 29, 2022

This PR supports encoding for datasets download and upload. The encoding setting is from profile.

Copy link

@std4lqi std4lqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Some background:

The encoding is for the code page used in ISPF, like IBM-1047 (if encoding is not specified), IBM-500, etc. As ISPF shows dataset contents with its own code page, this encoding option in profile helps the dataset will be saved in ISPF code page, in the case of upload. Otherwise, the character like !, [, ], etc might be shown wrong. Some European users suffered from it.

@zFernand0 , @JillieBeanSim Please run it from VS Code to see any problem for user in understanding the purpose of this encoding option.

@JillieBeanSim JillieBeanSim added this to the 2.4.0 milestone Oct 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 74.72% // Head: 74.72% // No change to project coverage 👍

Coverage data is based on head (fef3dc6) compared to base (c107749).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1942   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files          63       63           
  Lines        7067     7067           
  Branches     1523     1523           
=======================================
  Hits         5281     5281           
  Misses       1779     1779           
  Partials        7        7           
Impacted Files Coverage Δ
...xplorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts 70.18% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested using Zowe Explorer and works great! thanks @tiantn for the enhancement.

@JillieBeanSim JillieBeanSim merged commit e0fe5ff into main Oct 12, 2022
@JillieBeanSim JillieBeanSim deleted the zftp-encoding branch October 12, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants