New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zftp: support encoding for download and upload dataset #1942
Conversation
Signed-off-by: Tian Na <tiantn@cn.ibm.com>
Signed-off-by: Tian Na <tiantn@cn.ibm.com>
This PR supports encoding for datasets download and upload. The encoding setting is from profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Some background:
The encoding is for the code page used in ISPF, like IBM-1047 (if encoding is not specified), IBM-500, etc. As ISPF shows dataset contents with its own code page, this encoding option in profile helps the dataset will be saved in ISPF code page, in the case of upload. Otherwise, the character like !
, [
, ]
, etc might be shown wrong. Some European users suffered from it.
@zFernand0 , @JillieBeanSim Please run it from VS Code to see any problem for user in understanding the purpose of this encoding option.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportBase: 74.72% // Head: 74.72% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1942 +/- ##
=======================================
Coverage 74.72% 74.72%
=======================================
Files 63 63
Lines 7067 7067
Branches 1523 1523
=======================================
Hits 5281 5281
Misses 1779 1779
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested using Zowe Explorer and works great! thanks @tiantn for the enhancement.
Signed-off-by: Tian Na tiantn@cn.ibm.com
Proposed changes
Release Notes
Milestone:
Changelog:
Types of changes
What types of changes does your code introduce to Zowe Explorer?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the revieweryarn workspace vscode-extension-for-zowe vscode:prepublish
has been executedFurther comments