Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V2 Zowe Explorer README GIFs and remove keytar notice #2997

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

adam-wolfe
Copy link
Contributor

@adam-wolfe adam-wolfe commented Jul 11, 2024

Proposed changes

Replace old gifs in the Zowe Explorer README.md with new ones from Zowe Docs and remove the keytar notice, since it has been over a year since keytar was replaced.

Remove unused gifs.

Release Notes

Milestone: 2.17.0

Changelog: n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: adam-wolfe <122040687+adam-wolfe@users.noreply.github.com>
Signed-off-by: adam-wolfe <122040687+adam-wolfe@users.noreply.github.com>
@adam-wolfe adam-wolfe added the no-changelog Add to PR's that don't require a CHANGELOG update label Jul 11, 2024
@adam-wolfe adam-wolfe added this to the v2.17.0 milestone Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (141289c) to head (d495149).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         104      104           
  Lines       10889    10889           
  Branches     2386     2367   -19     
=======================================
  Hits        10186    10186           
  Misses        702      702           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adam-wolfe and others added 2 commits July 11, 2024 15:28
Signed-off-by: adam-wolfe <122040687+adam-wolfe@users.noreply.github.com>
Copy link

sonarcloud bot commented Jul 12, 2024

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-wolfe, the new GIFs look great!

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the readme and GIFs @adam-wolfe!

@traeok traeok merged commit 61992f1 into main Jul 12, 2024
28 checks passed
@traeok traeok deleted the v2-readme-gif-cleanup branch July 12, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Add to PR's that don't require a CHANGELOG update
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants