-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update V2 Zowe Explorer README GIFs and remove keytar notice #2997
Conversation
Signed-off-by: adam-wolfe <122040687+adam-wolfe@users.noreply.github.com>
Signed-off-by: adam-wolfe <122040687+adam-wolfe@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 104 104
Lines 10889 10889
Branches 2386 2367 -19
=======================================
Hits 10186 10186
Misses 702 702
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: adam-wolfe <122040687+adam-wolfe@users.noreply.github.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adam-wolfe, the new GIFs look great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for updating the readme and GIFs @adam-wolfe!
Proposed changes
Replace old gifs in the Zowe Explorer README.md with new ones from Zowe Docs and remove the keytar notice, since it has been over a year since keytar was replaced.
Remove unused gifs.
Release Notes
Milestone: 2.17.0
Changelog: n/a
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments