Decode an encoded DSN for unusual pds member names #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
jordanfilteau1995
approved these changes
May 30, 2019
|
Personally, I think you did this in the wrong place. I know of another product that has a problem due to an encoded URI, but not for a dataset. The decode of the URI needs to be done early, before it is even parsed. |
|
Good point, the server core should be doing this so that services dont need to. I'll open an issue on that point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for browsers to send requests for pds members with characters like # they need to do uri encoding, which means our code needs to uri decode before interpreting.
Related: zowe/zlux-app-manager#110
Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com