Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there something wrong with update method #3

Open
amberonno opened this issue Jan 3, 2018 · 0 comments
Open

Is there something wrong with update method #3

amberonno opened this issue Jan 3, 2018 · 0 comments

Comments

@amberonno
Copy link

amberonno commented Jan 3, 2018 •
edited
Loading

in MultiChild.js file

case UPDATE_TYPES.MOVE: DOM.insertChildAfter( parentNode, parentNode.childNodes[fromIndex], update.afterNode, ); break;
move method depends on 'fromIndex' (which is previous componet's _mountindex),which should be changed once some component insert before
feels like that move method should rely on real DOM node, but not _mountindex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amberonno