export: add command to export backup file to txt file #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
1023280072
commented
Sep 11, 2023
1023280072
commented
- add tcpmon/export.go
- add tcpmon/print_metric.go
- add tools/codegen.go to generate tcpmon/print_metric_tsdb.go
- add tcpmon/export.go - add tcpmon/print_metric.go - add tools/codegen.go to generate tcpmon/print_metric_tsdb.go
fanyang89
requested changes
Sep 11, 2023
cmd/export.go
Outdated
| hostname := args[1] | ||
|
|
||
| if net.ParseIP(hostname) == nil { | ||
| log.Fatal().Msg("Invalid IP address") |
cmd/export.go
Outdated
| log.Fatal().Msg("Invalid IP address") | ||
| } | ||
|
|
||
| var printer tcpmon.PrintMetric |
cmd/export.go
Outdated
| var printer tcpmon.PrintMetric | ||
| switch format { | ||
| case "tsdb": | ||
| printer = tcpmon.TSDBPrintMetric{} |
cmd/export.go
Outdated
|
|
||
| isEmpty, err := IsDirEmpty(dbDir) | ||
| if err != nil { | ||
| log.Fatal().Err(err).Msg("Check db directory failed, need an empty directory") |
There was a problem hiding this comment.
这里写 need an empty directory，但是 force = true 的情况又不需要一个空的目录。并且这里 err != nil 的情况下，也并不意味着 need an empty directory 的发生。
cmd/export.go
Outdated
| } | ||
| defer db.Close() | ||
|
|
||
| if !isEmpty { |
There was a problem hiding this comment.
好像可以直接 DropAll？因为他肯定是 empty，或者是有数据，反正不需要判断
cmd/export.go
Outdated
| func init() { | ||
| exportCmd.Flags().StringVarP(&format, "format", "f", "tsdb", "export backup to txt in this format") | ||
| exportCmd.Flags().StringVarP(&dbDir, "db", "d", "/tmp/tcpmon/export/db", "db path to restore backup") | ||
| exportCmd.Flags().BoolVarP(&force, "force", "e", false, "force restore, may overwrite files") |
There was a problem hiding this comment.
force 一般是 -f
这里冲突的情况，format 通常是可以忽略的，不经常用，所以 format 可能不需要 P
tcpmon/print_metric.go
Outdated
| @@ -0,0 +1,7 @@ | |||
| package tcpmon | |||
|
|
|||
| type PrintMetric interface { | |||
fanyang89
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.