Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
zph committed Apr 29, 2024
1 parent 6404a39 commit 5286f0a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion cli/args/flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9305,7 +9305,7 @@ mod tests {
install: true,
kernel: false,
conn_file: None,
directory: Some(PathBuf::from_str("/tmp/deno"))
directory: Some(PathBuf::from_str("/tmp/deno").unwrap()),
}),
..Flags::default()
}
Expand Down
12 changes: 8 additions & 4 deletions cli/tools/jupyter/install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,12 @@ pub fn install(directory: Option<PathBuf>) -> Result<(), AnyError> {
None => install_via_jupyter(),
};

if outcome.is_err() {
bail!("🆘 Failed to install Deno kernel");
match outcome {
Ok(()) => Ok(()),
Err(err) => {
println!("{}", err);
bail!();
}
}

println!("✅ Deno kernelspec installed successfully.");
Expand Down Expand Up @@ -96,11 +100,11 @@ fn create_kernelspec_in_directory(directory: &PathBuf) -> Result<(), AnyError> {
Ok(())
}


fn install_via_jupyter() -> Result<(), AnyError> {
let temp_dir = TempDir::new().unwrap();

let create_kernelspec_result =
create_kernelspec_in_directory(&temp_dir.path().to_path_buf());
let create_kernelspec_result = create_kernelspec_in_directory(&temp_dir.path().to_path_buf());
if create_kernelspec_result.is_err() {
return create_kernelspec_result;
}
Expand Down

0 comments on commit 5286f0a

Please sign in to comment.