Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding for ElementHandle.contentFrame() #23

Closed
zploskey opened this issue Mar 9, 2018 · 3 comments
Closed

Binding for ElementHandle.contentFrame() #23

zploskey opened this issue Mar 9, 2018 · 3 comments

Comments

@zploskey
Copy link
Owner

zploskey commented Mar 9, 2018

This should be included in Puppeteer 1.2.0 which is expected to be released on March 15th.

Docs

@jihchi
Copy link
Collaborator

jihchi commented Mar 14, 2018

I'm trying to make this binding, but I got dependency cycle error from following code (src/ElementHandle.re):

[@bs.send.pipe: t]
external contentFrame : unit => Js.Promise.t(Js.Nullable.t(Frame.t)) = "";

error message:

ninja: error: dependency cycle: src/Frame-BsPuppeteer.cmj -> src/FrameBase-BsPuppeteer.cmj -> src/ElementHandle-BsPuppeteer.cmj -> src/Frame-BsPuppeteer.cmj

Do you have any idea how to avoid this error?

@zploskey
Copy link
Owner Author

Whenever I have run into a dependency cycle I have started abstracting the types out into another module. I've just been putting them in Types.re. If you can't get rid of the cycle using what's there then you can add another type in that file.

@jihchi
Copy link
Collaborator

jihchi commented Mar 14, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants