Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zplug update shows inconsistent errors messages #326

Closed
agross opened this issue Dec 22, 2016 · 5 comments · Fixed by #349
Closed

zplug update shows inconsistent errors messages #326

agross opened this issue Dec 22, 2016 · 5 comments · Fixed by #349

Comments

@agross
Copy link
Contributor

agross commented Dec 22, 2016

Problem Summary

While running zplug update, errors are displayed inconsistently:

$ zplug update
[zplug] Start to update 19 plugins in parallel

 ✔  Up-to-date            zsh-users/zsh-completions
 ✔  Up-to-date            knu/z
 ✘  Unknown error         plugins/docker
 ✔  Up-to-date            plugins/docker-compose
 ✘  Repo not found        zsh-users/zsh-syntax-highlighting
 ✔  Up-to-date            kamranahmedse/git-standup
 ➜  Skip local repo       /home/agross/.dotfiles/zsh/themes
 ✔  Up-to-date            Tarrasch/zsh-bd
 ✔  Up-to-date            nvie/gitflow
 ✔  Up-to-date            grossweber/git-some
 ✔  Up-to-date            plugins/ssh-agent
 ✔  Up-to-date            bobthecow/git-flow-completion
 ✔  Updated!              zplug/zplug
 ✔  Up-to-date            plugins/gem
 ✔  Up-to-date            so-fancy/diff-so-fancy
 ✘  Unknown error         /home/agross/.dotfiles
 ✔  Up-to-date            plugins/sudo
 ✔  Up-to-date            plugins/systemd
 ✔  Up-to-date            rapid-git/rapid-git

[zplug] Elapsed time: 20.9477 sec.
 ==> Updating finished successfully!

Consider these two lines for local repos:

➜  Skip local repo       /home/agross/.dotfiles/zsh/themes
✘  Unknown error         /home/agross/.dotfiles

The second is a symlink to another directory, in case it matters.

From OMZ:

✘  Unknown error         plugins/docker
✔  Up-to-date            plugins/sudo

Repo excluded by if tag:

 ✘  Repo not found        zsh-users/zsh-syntax-highlighting
$ zplug list | sort
/home/agross/.dotfiles/zsh/themes  =>  as:"theme", from:"local", defer:"1", use:"agross.zsh-theme"
/home/agross/.dotfiles  =>  from:"local", defer:"1", use:"**/(aliases|postinit).zsh"
/home/agross/.dotfiles  =>  from:"local", defer:"2", use:"**/completion.zsh"
/home/agross/.dotfiles  =>  from:"local", use:"**/(^(zprofile|completion|postinit|aliases)).zsh"
bobthecow/git-flow-completion  =>  nil
grossweber/git-some  =>  if:"((1))", as:"command", use:"git-some"
kamranahmedse/git-standup  =>  if:"((1))", as:"command", use:"git-standup"
knu/z  =>  use:"z.sh", defer:"2"
nvie/gitflow  =>  if:"((1))", as:"command"
plugins/docker  =>  from:"oh-my-zsh", ignore:"oh-my-zsh.sh", if:"((0))"
plugins/docker-compose  =>  from:"oh-my-zsh", ignore:"oh-my-zsh.sh", if:"((0))"
plugins/gem  =>  from:"oh-my-zsh", ignore:"oh-my-zsh.sh", if:"((1)) || [[ -d ~/.rbenv/bin ]]"
plugins/ssh-agent  =>  from:"oh-my-zsh", ignore:"oh-my-zsh.sh"
plugins/sudo  =>  from:"oh-my-zsh", ignore:"oh-my-zsh.sh", if:"((0))"
plugins/systemd  =>  from:"oh-my-zsh", ignore:"oh-my-zsh.sh", if:"((0))"
rapid-git/rapid-git  =>  if:"((1))"
so-fancy/diff-so-fancy  =>  if:"((1 + 1 + 1 == 3))", as:"command", use:"diff-so-fancy"
Tarrasch/zsh-bd  =>  nil
zplug/zplug  =>  nil
zsh-users/zsh-completions  =>  nil
zsh-users/zsh-syntax-highlighting  =>  defer:"2", if:"[[ windows != windows ]]"

System Information

  • zsh version 5.1.2
  • zplug version/commit 4ae482d
@paulhybryant
Copy link

I ran into the same issue.

The repo is excluded and then 'Repo not found' is reported.

@paulhybryant
Copy link

From the demo it seems it should report 'skip due to if', not 'Repo not found'

@babarot
Copy link
Member

babarot commented Dec 29, 2016

Show me your the output of zplug --log | grep YOUR_ERROR_MESSAGE when the error occur

@agross
Copy link
Contributor Author

agross commented Dec 29, 2016

\{"pid":10948,"shlvl":1,"level":"ERROR","dir":"/home/agross/.cache/zplug/repos/zsh-users/zsh-completions","message":"From\ https://github.com/zsh-users/zsh-completions\n\ \ \ 75b70de..e88b3bc\ \ master\ \ \ \ \ -\>\ origin/master","trace":\["__zplug::log::capture::error:8","__zplug::utils::git::merge:26","__zplug::sources::github::update:9","\(eval\):1","__zplug::core::sources::use_handler:13","__update__:60","__zplug::core::core::run_interfaces:14","zplug:12","/usr/bin/zsh:2"\],"date":"2016-12-29T13:10:45+0100"\}

@babarot babarot added the BUG label Jan 5, 2017
@agross
Copy link
Contributor Author

agross commented Jan 5, 2017

Here's how it looks like on a Linux machine:

https://monosnap.com/file/Sh8wAWCmvVWiBYhknYKyVliJbJF4rU

babarot added a commit that referenced this issue Jan 6, 2017
This is because grep may not be able to correctly distinguish tab characters.
In order to solve this, added a ltsv parser written by awk.

- Fix #326 (see also second commit in P-R #344), fix #348
- Add `__zplug::utils::awk::ltsv function`
@babarot babarot mentioned this issue Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants