Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZPLUG_LOADFILE doesn't accept relative paths #440

Open
1 of 4 tasks
gaerfield opened this issue Nov 4, 2017 · 2 comments
Open
1 of 4 tasks

ZPLUG_LOADFILE doesn't accept relative paths #440

gaerfield opened this issue Nov 4, 2017 · 2 comments

Comments

@gaerfield
Copy link

  • Type:
    • Bug
    • Enhancement
    • Feature Request
    • Question

  • zplug --version: 2.4.1
  • zsh --version: zsh 5.1.1 (x86_64-ubuntu-linux-gnu)
  • uname -a: Linux 4.4.0-98-generic #121-Ubuntu SMP Tue Oct 10 14:24:03 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
  • GNU Awk 4.1.3, API: 1.1 (GNU MPFR 3.1.4, GNU MP 6.1.0)
  • Ubuntu 16.04.3 LTS

Minimal zshrc

export ZPLUG_LOADFILE="~/.dotfiles/zsh/packages.zsh"
source ~/.zplug/init.zsh

if ! zplug check; then
    zplug install
fi

zplug load

Step to reproduce

  1. git clone <zplug-repo> ~/.zplug
  2. cp ~/.zplug/packages.zsh ~/.dotfiles/zsh/packages.zsh
  3. start terminal

zplug --log contains
{"pid":7441,"shlvl":1,"level":"INFO","dir":"/home/gaerfield","message":"ZPLUG_LOADFILE is not found","trace":["__zplug::log::write::info:2","__zplug::io::file::load:3","/home/user/gaerfield/init.zsh:33","/home/gaerfield/.zshrc:9","zsh:0"],"date":"2017-11-04T18:23:23+0100"}

What you want

An info in the docs (https://github.com/zplug/zplug#zplug_loadfile), to use smth like export ZPLUG_LOADFILE="${ZDOTDIR:-$HOME}/where/ever/thefile.zsh"

babarot added a commit that referenced this issue Dec 26, 2017
@babarot
Copy link
Member

babarot commented Dec 26, 2017

Maybe fixed. Please tests on fix-440 branch

@babarot
Copy link
Member

babarot commented Dec 28, 2017

Speaking strictly, you should not do quoting ZPLUG_LOADFILE env when using tilde because the shell does not expand it even if including tilde. But in this patch, it expand tilde forcely. I'll merge into v2.4.2 branch for releasing because I could confirm it works.

babarot added a commit that referenced this issue Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants