Plugins report fail inspite of installing

[HaoZeke]

• Type:
  • Bug
  • Enhancement
  • Feature Request
  • Question

---

• zplug --version: 2.4.1
• zsh --version: zsh 5.4.2 (x86_64-unknown-linux-gnu)
• uname -a: Linux myi7archbox 4.14.7-1-ck-haswell Implement update command #1 SMP PREEMPT Sun Dec 17 12:22:53 EST 2017 x86_64 GNU/Linux

Minimal zshrc

Only reproducing the erroneos plugin code.

source ~/.zplug/init.zsh

if ! command -v exa >/dev/null 2>&1; then
  zplug "ogham/exa", \
    from:gh-r, \
    as:command, \
    rename-to:exa, \
    use:"*linux*"
fi

if zplug check || zplug install; then
  zplug load --verbose
fi

Step to reproduce

1. Try running the minimal zshrc
2. It will report the installation failed
3. The binary is still correctly placed in .zplug/bin and works correctly however.

[babarot]

Thank you for reporting. Please test on fix-447 branch sinse I fixed this problem maybe. If it is cleared, I'll merge and release this patch on next version.

[HaoZeke]

Hi, Thanks for the prompt response...

So the fix-447 branch fixed the install for exa, however that branch had the following issues:

• zplug update --self returns [zplug] --self: unknown option [actually this is true of the master branch too so I guess it's a depreciated option]
• More importantly another program fails to install

The program is archiver and the relevant portion is:

if ! command -v archiver >/dev/null 2>&1; then
  zplug "mholt/archiver", \
    from:gh-r, \
    as:command, \
    rename-to:archiver, \
    use:"*linux*amd64*"
fi

With the new branch /home/haozeke/.zplug/repos/mholt/archiver/archiver_linux_amd64 is created but the symlink to home/haozeke/.zplug/bin/archiver is not created.

I can confirm also, that with the master branch there is no error for archiver and it works perfectly.

TL;DR: not ready to be merged as it causes a real installation error (as opposed to the false positive reported for exa)

[babarot]

Thank you for catching that. About second problem, I know the cause so I can fix this soon.

BTW, the format of artifact that is hosted on GitHub Releases varies from project to project. Therefore, it is very difficult to handle these uniformly.

Anyway thanks.

[babarot]

I just pushed new commit for fixing those problem 57115de

[HaoZeke]

Yup, that fixed everything 👍
Thanks a ton..

I know it must be really difficult, which is why zplug is the only manager to offer this kind of functionality...

Great work and thanks again! 💯