Skip to content

Commit

Permalink
Merge pull request #13 from zpriddy/bots_config
Browse files Browse the repository at this point in the history
Fix bots config
  • Loading branch information
zpriddy committed Feb 13, 2020
2 parents 79dcb0f + 9e06e67 commit c5d6a48
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 16 deletions.
4 changes: 0 additions & 4 deletions example/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
from dotenv import load_dotenv

load_dotenv(verbose=False)

FLASK_PORT = 8083
FLASK_HOST = "127.0.0.1"
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ExamplePlugin:
enabled: yes
bot:
name: glados
name: ExampleBot
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = glados
version = 0.0.1-dev9
version = 0.0.1-dev10
description = A library to help with slackbot development
long_description = file: README.md
long_description_content_type = text/markdown
Expand Down
1 change: 0 additions & 1 deletion src/glados/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ def import_plugins(self):
importer.load_discovered_plugins_config(False)
importer.import_discovered_plugins(self.bots)
for plugin in importer.plugins.values():
print(type(plugin))
self.add_plugin(plugin)
logging.info(f"successfully imported {len(self.plugins)} plugins")

Expand Down
10 changes: 7 additions & 3 deletions src/glados/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
GladosRequest,
VERIFY_ROUTES,
EventRoutes,
PyJSON,
)

from slack.web.classes.messages import Message
Expand Down Expand Up @@ -50,6 +51,7 @@ def __init__(
self.enabled = enabled
self.bot = PluginBotConfig(**bot)
self.config_file = config_file
self.config = PyJSON(kwargs)

package = config_file.replace("/", ".")
package = package.replace(".config.yaml", "")
Expand Down Expand Up @@ -147,15 +149,16 @@ def load_discovered_plugins_config(self, write_to_user_config=True):

with open(user_config_path) as file:
c = yaml.load(file, yaml.FullLoader)

if len(c.keys()) != 1:
logging.critical(
f"zero or more than one object in config file: {config_file}"
)
continue

c[plugin_name]["config_file"] = str(user_config_path)
plugin_user_config = PluginConfig(plugin_name, **c[plugin_name])
plugin_user_config.update(plugin_package_config)

self.plugin_configs[plugin_name] = plugin_user_config

def import_discovered_plugins(self, bots: Dict[str, GladosBot]):
Expand Down Expand Up @@ -220,8 +223,9 @@ class GladosPlugin:
"""

def __init__(self, config: PluginConfig, bot: GladosBot, **kwargs):
self.config = config
self.name = self.config.name
self.name = config.name
self._config = config
self.config = config.config
self.bot = bot

self._routes = dict() # type: Dict[int, Dict[str, GladosRoute]]
Expand Down
5 changes: 3 additions & 2 deletions tests/plugins/test_plugin_1/test_plugin_1.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
from glados import GladosBot, GladosPlugin
from glados.plugin import PluginConfig
import logging


class TestPlugin1(GladosPlugin):
def __init__(self, bot: GladosBot, name, **kwargs):
super().__init__(name, bot, **kwargs)
def __init__(self, config: PluginConfig, bot: GladosBot, **kwargs):
super().__init__(config, bot, **kwargs)
logging.info(f"plugin {self.name} imported")

def test_function(self, echo, **kwargs):
Expand Down
5 changes: 3 additions & 2 deletions tests/plugins/test_plugin_2/test_plugin_2.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
from glados import GladosBot, GladosPlugin
from glados.plugin import PluginConfig
import logging


class TestPlugin2(GladosPlugin):
def __init__(self, bot: GladosBot, name, **kwargs):
super().__init__(name, bot, **kwargs)
def __init__(self, config: PluginConfig, bot: GladosBot, **kwargs):
super().__init__(config, bot, **kwargs)
logging.info(f"plugin {self.name} imported")

def test_function(self, echo, **kwargs):
Expand Down
5 changes: 3 additions & 2 deletions tests/plugins/test_plugin_3/test_plugin_3.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
from glados import GladosBot, GladosPlugin
from glados.plugin import PluginConfig
import logging


class TestPlugin3(GladosPlugin):
def __init__(self, bot: GladosBot, name, **kwargs):
super().__init__(name, bot, **kwargs)
def __init__(self, config: PluginConfig, bot: GladosBot, **kwargs):
super().__init__(config, bot, **kwargs)
logging.info(f"plugin {self.name} imported")

def test_function(self, echo, **kwargs):
Expand Down

0 comments on commit c5d6a48

Please sign in to comment.