Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssGSEA ignores parameters in 1.0.4 #194

Closed
verheytb opened this issue Mar 21, 2023 · 3 comments
Closed

ssGSEA ignores parameters in 1.0.4 #194

verheytb opened this issue Mar 21, 2023 · 3 comments

Comments

@verheytb
Copy link

verheytb commented Mar 21, 2023

Python 3.10.9
Linux-5.15.90.1-microsoft-standard-WSL2-x86_64-with-glibc2.35
gseapy 1.0.4

Calling gseapy.ssgsea should have working parameters. While the gene_sets and data parameters are passed, others (including min_size, max_size, verbose, etc) are not. I think I have located the offending code to line 259 in __init__.py

image

@verheytb verheytb changed the title ssGSEA no longer allows parameters in 1.0.4 ssGSEA ignores parameters in 1.0.4 Mar 22, 2023
@chuiqin
Copy link

chuiqin commented Apr 17, 2023

I also encountered the same problem. How did you solve it?

zqfang pushed a commit that referenced this issue Apr 17, 2023
@joshscurll
Copy link

joshscurll commented Apr 27, 2023

FYI, I have also just encountered this issue after updating to GSEApy v1.0.4 (installed with pip in a Conda environment running Python 3.9). This issue does not exist in GSEApy v1.0.3. When stepping through the GSEApy v1.0.4 ssgsea code in debug mode in a jupyter lab notebook, kwargs appears to be an empty dictionary when we reach line 259 in __init__.py, though I couldn't figure out from the preceding code why this happens.

@zqfang
Copy link
Owner

zqfang commented Jun 15, 2023

Fixed in v1.0.5

@zqfang zqfang closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants