Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added device_id and device_name as potential authorize_options #291

Closed
wants to merge 2 commits into from
Closed

Added device_id and device_name as potential authorize_options #291

wants to merge 2 commits into from

Conversation

j-mie
Copy link

@j-mie j-mie commented Jul 5, 2017

When using a private IP range you'll get the following error: "That’s an error. Error: invalid_request device_id and device_name are required for private IP:"

If you specify those 2 arguments then Google will allow you to use OAuth.

I couldn't find any documentation for these two arguments, but I know specifiying them makes it work :)

@zquestz
Copy link
Owner

zquestz commented Jul 8, 2017

Happy to include this but we need to squash the commits and add tests =)

@j-mie
Copy link
Author

j-mie commented Jul 8, 2017

What tests would you like to see? I don't code Ruby or generally write many tests so some pointers here would be great :)

You should be able to sqaush the commits when you merge it, there should be a sqaush and merge option.

@zquestz
Copy link
Owner

zquestz commented Jul 12, 2017

Thanks for the patch. I went ahead and added device_id and device_name to master with tests. =)

@zquestz zquestz closed this Jul 12, 2017
@j-mie
Copy link
Author

j-mie commented Jul 12, 2017

Awesome, thanks.

@j-mie j-mie deleted the patch-1 branch July 12, 2017 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants