Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Redirect Uri #414

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Fix Redirect Uri #414

merged 2 commits into from
Nov 24, 2021

Conversation

matiassalles99
Copy link
Contributor

  • When passing redirect url via query param & code or access token via body the redirect url was not being overriden
  • Allow redirect url also via body

@matiassalles99
Copy link
Contributor Author

Screen Shot 2021-11-10 at 18 17 21

Travis CI failing for unrelated reason

@matiassalles99 matiassalles99 mentioned this pull request Nov 11, 2021
Closed
@zquestz
Copy link
Owner

zquestz commented Nov 12, 2021

If you can add a test that would be epic.

@matiassalles99
Copy link
Contributor Author

Will do so!

@matiassalles99
Copy link
Contributor Author

@zquestz Just added the test, please let me know if its okay or you have any improvements/suggestions of this or another test to do before merging

@matiassalles99
Copy link
Contributor Author

Also, this pr might close this issue #391, in case you want to check it out

@zquestz zquestz merged commit 475efe4 into zquestz:master Nov 24, 2021
@matiassalles99 matiassalles99 deleted the fix/redirect-uri branch November 24, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zquestz zquestz zquestz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matiassalles99 @zquestz