fix #184 : i386 build failure timeoutconn iovec len #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @problame, I’m not sure what you mean when you say the Makefile doesn’t produce a binary? Do you mean that i386 isn’t supported because the current build fails? Does this actually need old hardware for end-to-end testing, or is it enough to install the i386 version of FreeBSD on new hardware or a VM and test? |
|
It means: no-one did any testing on i386, hence we don't produce a binary in the official Makefile. |
Go 1.13 will add a more precise escape analysis: https://tip.golang.org/doc/go1.13#compiler Reviewed usage of unsafe to ensure we adhere to the unsafe.Pointer safety rules: https://tip.golang.org/pkg/unsafe/#Pointer
problame
force-pushed
the
problame/184-i386-build-failure-timeoutconn-iovec-len
branch
from
53931a6
to
254a292
Compare
problame
deleted the
problame/184-i386-build-failure-timeoutconn-iovec-len
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An actual end-to-end test on i386 would be nice before merging this.
On the other hand, this work merely makes zrepl compile on i386, we don't 'officially' support i386 because the Makefile doesn't produce a binary.
What do you think, @woodsb02?