Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix | Uncheckable domain #25

Merged
merged 11 commits into from
May 6, 2021
Merged

Bugfix | Uncheckable domain #25

merged 11 commits into from
May 6, 2021

Conversation

zrosenbauer
Copy link
Owner

By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@zrosenbauer
Copy link
Owner Author

Fix for #24

@zrosenbauer zrosenbauer added the bugfix Something is broke but not on fire. label May 6, 2021
@zrosenbauer
Copy link
Owner Author

@zrosenbauer zrosenbauer merged commit ba35b85 into main May 6, 2021
@zrosenbauer zrosenbauer deleted the bugfix/uncheckable-domain branch May 6, 2021 18:21
zrosenbauer pushed a commit that referenced this pull request Nov 9, 2021
* fix issue with invalid domain

* fix test

* fix fmt

* add build

* fix format

* fix format

* fixes etc

* Try the #24 error

* fix ci

* revert 1 off test

* update package & rebuild
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something is broke but not on fire.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant