Do not use bare except

zrzka · Oct 25, 2017 · 5a46f19 · 5a46f19
1 parent e82ab1d
commit 5a46f19
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/blackmamba/script/run_unit_tests.py b/blackmamba/script/run_unit_tests.py
@@ -52,7 +52,7 @@ def _parse_log_file():
 
     try:
         suite = ET.parse(_LOG_FILE_PATH).getroot()
-    except:
+    except Exception:
         return
 
     if not suite.tag == 'testsuite':

diff --git a/blackmamba/update.py b/blackmamba/update.py
@@ -42,7 +42,7 @@ def get_local_release():
     try:
         with open(_RELEASE_PATH, 'rt') as input:
             return json.load(input)
-    except:
+    except Exception:
         pass
 
 
@@ -70,7 +70,7 @@ def _get_json(command):
 def _get_latest_release():
     try:
         return _get_json('releases/latest')
-    except:
+    except Exception:
         pass
 
 

diff --git a/env.py b/env.py
@@ -90,7 +90,7 @@ def toggle():
                           'Switch to Working Copy version?',
                           'OK')
             switch_to_working_copy()
-    except:
+    except Exception:
         pass
 
 

diff --git a/install.py b/install.py
@@ -33,7 +33,7 @@ def _cleanup():
                     shutil.rmtree(path)
                 else:
                     os.remove(path)
-            except:
+            except Exception:
                 pass
 
     _cleanup_paths = None