New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Improve typing #101
🔧 Improve typing #101
Conversation
Codecov ReportBase: 100.00% // Head: 99.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
===========================================
- Coverage 100.00% 99.64% -0.36%
===========================================
Files 18 18
Lines 539 556 +17
Branches 91 93 +2
===========================================
+ Hits 539 554 +15
- Misses 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Overview
I naively implemented typing. It was time to give it some much needed attention. Now IDEs and mypy will correctly interpret types for all methods on
Commands
andCommandsAsync
except forquery_multiple
andquery_multiple_async
. I have a TODO to explore variadic typevars (TypeVarTuple
) for this in the future.Changes
TypeVar
to provide a better typing experience onCommands
andCommandsAsync