New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add support for psycopg3
#214
✨ add support for psycopg3
#214
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 21 +1
Lines 569 582 +13
Branches 98 100 +2
=========================================
+ Hits 569 582 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This looks great, thank you! One comment - I don’t think we need both psycopg and psycopg-binary as deps. Can we keep just the binary? |
From my understanding https://pypi.org/project/psycopg-binary/ -> You can read here the description |
ah okay - can you remove it and reinstall it like poetry add 'psycopg[binary]' --optional should add it to the toml how i would expect. Didn't realize it was just an extra |
Should be good now. |
Doesn't need to happen in this PR, but I would also like to add the psycopg3 async api as one of the async drivers. If you wanted to PR that that'd be amazing, otherwise I'll look to add it in a couple weeks |
#218 here it is :) |
I have not set
psycopg3
as a default dbapi driver for PostgreSQL inpydapper
.But we can change that if you decide to do so.