Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully quit the browser instance when Close is called #155

Open
phanirithvij opened this issue Jul 27, 2021 · 2 comments
Open

Gracefully quit the browser instance when Close is called #155

phanirithvij opened this issue Jul 27, 2021 · 2 comments

Comments

@phanirithvij
Copy link

phanirithvij commented Jul 27, 2021

Can the browser be closed gracefully instead of quitting abruptly?

chromedp has it implemented

I'm requesting it because the examples, when run with the same user-data-directory over multiple runs instead of using temporary ones and discarding each time, led to the following issue:

image

The second one opens saying chrome/browser crashed in the previous run.

@hassandraga
Copy link

True, Lorca should do the same as WebUI.
https://github.com/alifcommunity/webui

@williamleecn
Copy link

fixed it by:

os.Remove("./tmp/Default/Preferences")

ui, err := lorca.New("", "./tmp", 480, 320, args...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants