Some refactoring and more tests to url resolver.

zsh-users · Jul 18, 2012 · 1cae4fc · 1cae4fc
1 parent a5e21a6
commit 1cae4fc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/antigen.zsh b/antigen.zsh
@@ -69,13 +69,13 @@ antigen-bundle () {
 
     local url="$1"
 
+    # Expand short github url syntax: `username/reponame`
     if [[ $url != git://* && \
             $url != https://* && \
             $url != /* && \
             $url != git@github.com:*/*
             ]]; then
-        url="${url%.git}"
-        url="https://github.com/$url.git"
+        url="https://github.com/${url%.git}.git"
     fi
 
     echo "$url"

diff --git a/tests/url-resolver.t b/tests/url-resolver.t
@@ -11,6 +11,15 @@ Complete urls.
   $ resolve git@github.com:zsh-users/antigen.git
   git@github.com:zsh-users/antigen.git
 
+Complete github urls, missing the `.git` suffix.
+
+  $ resolve https://github.com/zsh-users/antigen
+  https://github.com/zsh-users/antigen
+  $ resolve git://github.com/zsh-users/antigen
+  git://github.com/zsh-users/antigen
+  $ resolve git@github.com:zsh-users/antigen
+  git@github.com:zsh-users/antigen
+
 Just username and repo name.
 
   $ resolve zsh-users/antigen