Skip to content

Commit

Permalink
Merge pull request #454 from zsh-users/develop
Browse files Browse the repository at this point in the history
v0.6.3
  • Loading branch information
ericfreese committed Jun 24, 2019
2 parents c806055 + 0636a39 commit 146020d
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 5 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Changelog

## v0.6.3
- Fixed bug moving cursor to end of buffer after accepting suggestion (#453)

## v0.6.2
- Fixed bug deleting the last character in the buffer in vi mode (#450)
- Degrade gracefully when user doesn't have `zsh/system` module installed (#447)
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v0.6.2
v0.6.3
3 changes: 2 additions & 1 deletion spec/options/widget_lists_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@
context 'when added to ZSH_AUTOSUGGEST_ACCEPT_WIDGETS' do
let(:options) { ["ZSH_AUTOSUGGEST_ACCEPT_WIDGETS+=(#{widget})"] }

it 'accepts the suggestion when invoked' do
it 'accepts the suggestion and moves the cursor to the end of the buffer when invoked' do
with_history('echo hello') do
session.send_string('e')
wait_for { session.content }.to eq('echo hello')
session.send_keys('C-b')
wait_for { session.content(esc_seqs: true) }.to eq('echo hello')
wait_for { session.cursor }.to eq([10, 0])
end
end
end
Expand Down
6 changes: 5 additions & 1 deletion src/widgets.zsh
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,11 @@ _zsh_autosuggest_accept() {
unset POSTDISPLAY

# Move the cursor to the end of the buffer
CURSOR=${max_cursor_pos}
if [[ "$KEYMAP" = "vicmd" ]]; then
CURSOR=$(($#BUFFER - 1))
else
CURSOR=$#BUFFER
fi
fi

_zsh_autosuggest_invoke_original_widget $@
Expand Down
8 changes: 6 additions & 2 deletions zsh-autosuggestions.zsh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Fish-like fast/unobtrusive autosuggestions for zsh.
# https://github.com/zsh-users/zsh-autosuggestions
# v0.6.2
# v0.6.3
# Copyright (c) 2013 Thiago de Arruda
# Copyright (c) 2016-2019 Eric Freese
#
Expand Down Expand Up @@ -398,7 +398,11 @@ _zsh_autosuggest_accept() {
unset POSTDISPLAY

# Move the cursor to the end of the buffer
CURSOR=${max_cursor_pos}
if [[ "$KEYMAP" = "vicmd" ]]; then
CURSOR=$(($#BUFFER - 1))
else
CURSOR=$#BUFFER
fi
fi

_zsh_autosuggest_invoke_original_widget $@
Expand Down

0 comments on commit 146020d

Please sign in to comment.