Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a symlink instead of file #640

Closed
wants to merge 3 commits into from

Conversation

grigorii-horos
Copy link

@grigorii-horos grigorii-horos commented Nov 20, 2021

${0} not compatible with some zsh plugin managers

@ericfreese
Copy link
Member

My understanding is that the sym link doesn't work in some environments like windows mSYS2 (see PR #156). It looks like zsh-syntax-highlighting may have an approach that works for both. Can you try implementing this here instead?

https://github.com/zsh-users/zsh-syntax-highlighting/blob/c7caf57ca805abd54f11f756fda6395dd4187f8a/zsh-syntax-highlighting.plugin.zsh

@grigorii-horos
Copy link
Author

My understanding is that the sym link doesn't work in some environments like windows mSYS2

Oops… I didn't know.

Maybe we can use this for $0 handling?

ericfreese added a commit that referenced this pull request Sep 7, 2023
This commit is based on [zsh-syntax-highlighting's similar commit][1].

Also, motivated from PR #640.

[1]: zsh-users/zsh-syntax-highlighting@750aebc
@ericfreese
Copy link
Member

@grigorii-horos I've created a PR (#759) that takes the implementation from zsh-syntax-highlighting. I realize this PR is very old, but take a look if you're able. I'll likely merge it soon.

@ericfreese ericfreese closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants