Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-annex zsh completion #146

Closed
esc opened this issue May 24, 2013 · 5 comments
Closed

git-annex zsh completion #146

esc opened this issue May 24, 2013 · 5 comments

Comments

@esc
Copy link

esc commented May 24, 2013

Would you be interested in migrating: https://github.com/esc/git-annex-zsh-completion to here? Would appreciate some review on it too, if you think it sucks.

@nicoulaj
Copy link
Member

Of course, contributions are welcome !

As for the code, I think the python calls are subject to breakage... You may want to at least make sure:

  • It works with Python 2 and 3, because the default python can be basically anything accross systems
  • python errors are properly handled (eg if python is missing, or modules are missing, etc)

@Valodim
Copy link
Member

Valodim commented Nov 7, 2013

can't you just parse the output of git annex status without the --json? the annex output might be less stable than with json, but in the end you will have to deal with situations where you don't get all keys you expect anyways, so losing the python dependency might be worth it.

@esc
Copy link
Author

esc commented Nov 7, 2013

i probably could, but not anytime soon.

@esc
Copy link
Author

esc commented Feb 12, 2015

My version has been superseded by:

https://github.com/Schnouki/git-annex-zsh-completion

cc @Schnouki

@nicoulaj
Copy link
Member

Closing, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants