Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter parsing does not honor SH_WORD_SPLIT #818

Closed
akhiljalagam opened this issue Jun 26, 2021 · 3 comments
Closed

Parameter parsing does not honor SH_WORD_SPLIT #818

akhiljalagam opened this issue Jun 26, 2021 · 3 comments
Labels
Bug good first issue syntax:command-word

Comments

@akhiljalagam
Copy link

image
but that aws_head command works fine.
@phy1729
Copy link
Member

phy1729 commented Jun 26, 2021

In general that's correct as zsh will error with zsh: command not found: aws --profile foo --output --text. However, I presume you have shwordsplit set which the parameter parsing code doesn't yet know about. The easy solutions are use a function, or an alias, or an array; but we should handle shwordsplit as well.

@phy1729 phy1729 changed the title No green highlighting for variables containing a command Parameter parsing does not honor SH_WORD_SPLIT Jun 26, 2021
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Jun 29, 2021
@phy1729
main: Honor shwordsplit when expanding parameters
f0e6a8e 
Closes zsh-users#687, zsh-users#818.
@phy1729
Copy link
Member

phy1729 commented Jun 29, 2021

Fixed in f0e6a8e (seems I should have repeated the closes magic word).

@phy1729 phy1729 closed this as completed Jun 29, 2021
@danielshahaf
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug good first issue syntax:command-word
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phy1729 @danielshahaf @akhiljalagam