fix _zsh_highlight_load_highlighters when executing zsh with sudo rights

[qoomon]

I am facing following error message if i start my zsh with sudo right e.g. sudo zsh

Error Log
_zsh-syntax-highlighting: 'README.md' highlighter should define both required functions '_zsh_highlight_highlighter_README.md_paint' and 'zsh_highlight_highlighter_README.md_predicate' in '/Users/USERNAME/.zsh.zgem/gems/zsh-syntax-highlighting/highlighters/README.md/README.md-highlighter.zsh'.

this is caused by a really strange behaviour of zsh itself.

ZSH Issue Example

If you create a file and folder

mkdir -p folder
touch file

...,if you want to print only folders globing works as expected

echo ./*/
>> ./folder/

..., however if you run the same command with sudo it will also print the file, as a folder.
thats totally weird.

sudo zsh -c 'echo ./*/'
>> ./file/ ./folder/

Solution

Because thats a zsh issue I adjust the globing expression, now it works as expected.

[danielshahaf]

Cross-referencing #506. More below

..., however if you run the same command with sudo it will also print the file, as a folder.
thats totally weird.

sudo zsh -c 'echo ./*/'

./file/ ./folder/

I can't reproduce that. Please change -c to -fc and try again. What's the zsh version, distro, and mount output for the relevant mountpoint?

Solution

Because thats a zsh issue I adjust the globing expression, now it works as expected.

Thanks for the analysis. I'd still like to double-check whether it's really a bug in the */ syntax, before I avoid it.

[qoomon]

macOS 10.13.4 (17E202)
zsh 5.5.1 (x86_64-apple-darwin17.5.0)

I changed parameter to -fc still wrong result with sudp

[danielshahaf]

Thanks. I'm on Linux, so I'll wait for an OS X -using dev to weigh in. In the meantime, could you please confirm that `zsh --version` and `sudo zsh --version` are the same value?

…

macOS 10.13.4 (17E202) zsh 5.5.1 (x86_64-apple-darwin17.5.0) I changed parameter to `-fc` still wrong result with sudp -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #518 (comment)

[danielshahaf]

The zsh bug was reported as workers/42891 : http://www.zsh.org/cgi-bin/mla/redirect?WORKERNUMBER=42891

[qoomon]

It was me :-D

so i test with ubuntu and i can not reproduce it there, however i tried it on macos of my colleges and it seem like its not a problem only on my mashines

[qoomon]

zsh --version => zsh 5.5.1 (x86_64-apple-darwin17.5.0)
sudo zsh --version => zsh 5.5.1 (x86_64-apple-darwin17.5.0)

[qoomon]

Hey, would be great if you could except my pull request, cause I think it will take some time until zsh is fixed :-(
And may patch is only 3 characters long :-D

[phy1729]

I'd like to move to autoloading the highlighters in the future, but this patch is tiny as you point out, so I think it's reasonable to merge it. Could you rebase into a single commit and match the commit message style? (Something like main: Add glob qualifier to work around zsh/macOS bug and perhaps link to the mailing list thread as well.)

[qoomon]

done

[phy1729]

Thanks for the report and fix!