Add zstd file completion to tar #45
Conversation
| @@ -20,8 +20,10 @@ if [[ "$1" = *[urtx]* ]]; then | |||
| _files "$expl[@]" -g '*.(tar|TAR).bz2(-.)' | |||
| elif [[ "$1" = *J* ]]; then | |||
| _files "$expl[@]" -g '*.(tar|TAR).(lzma|xz)(-.)' | |||
| elif [[ "$1" = *zstd* ]]; then | |||
There was a problem hiding this comment.
zstd is never assigned to "$1" (which comes from $_tar_cmd) so under what condition will this condition evaluate to true? In the absense of a single letter option to tar for zstd, I'm not sure how _tar should be changed to adapt to this. Perhaps replace _tar_cmd with a more specific _tar_compression variable.
There was a problem hiding this comment.
You're right. I thought I tested this locally but it was an old file. I had a look for an obvious way to implement what you said but I'm not really knowledgable enough about the structure of this whole completion structure to be honest.
| elif [[ "$_cmd_variant[$service]" == (gnu|libarchive) ]]; then | ||
| _files "$expl[@]" -g '*.((tar|TAR)(.gz|.GZ|.Z|.bz2|.lzma|.xz|)|(tbz|tgz|txz))(-.)' |
There was a problem hiding this comment.
Have you verified with both libarchive and GNU tar? I only have the libarchive variant available to me and it appears to have a --zstd option with no short form.
There was a problem hiding this comment.
There was a problem hiding this comment.
GNU tar supports --zstd too, with no short form either.
Completion/Unix/Type/_tar_archive
Outdated
| elif [[ "$_cmd_variant[$service]" == (gnu|libarchive) ]]; then | ||
| _files "$expl[@]" -g '*.((tar|TAR)(.gz|.GZ|.Z|.bz2|.lzma|.xz|)|(tbz|tgz|txz))(-.)' | ||
| _files "$expl[@]" -g '*.((tar|TAR)(.gz|.GZ|.Z|.bz2|.lzma|.xz|.zst|.zstd)|(tbz|tgz|txz|tzst|tzstd))(-.)' |
There was a problem hiding this comment.
Are tzst and and tzstd extensions really a thing or are you just making assumptions while copy/pasting? The original purpose behind tgz, tbz extensions was to cope with 8.3 filename limitations on old operating systems so they mostly are just a relic from the past. tzst doesn't even fit in 3 characters.
There was a problem hiding this comment.
Oh, today I learned. I had no idea it was more than just an abbreviation for the heck of it. So to answer your question: It was just an assumption that this kind of abbreviation should be continued. However, I see now that it doesn't really make sense. I'll remove it.
|
Looks like someone applied a similar patch separately covering .lzo too. Sorry, I should have got around to applying this quicker. I'll close this now. Thanks for the contribution. If you're unhappy with the state of the function in the current git repo, you can always open a fresh request. |
|
Eh, it's fine. If it works, it works. |
zstd is a modern compression format that is gaining more support. For instance, Arch Linux recently switched its packages to .zstd.