Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed test package #39

Closed
wants to merge 1 commit into from
Closed

Add missed test package #39

wants to merge 1 commit into from

Conversation

ratson
Copy link

@ratson ratson commented Jul 19, 2015

make test requires mock

@zsiciarz
Copy link
Owner

Hi r4ts0n and thanks for the PR! However the omission of mock is intended as I mentioned before in #35. I support Python 2.7 only because sometimes I have to, otherwise I do my development on 3. If you take a look at tox.ini, you'll see mock being installed for old Python versions. Perhaps I should update the development docs to be more explicit about Py3-first approach.

@zsiciarz zsiciarz closed this Jul 19, 2015
@ratson
Copy link
Author

ratson commented Jul 19, 2015

Understood, it would be great to have a Python 2 note about pip install mock in https://github.com/zsiciarz/django-envelope/blob/master/docs/development.rst

@zsiciarz
Copy link
Owner

If you have a note in mind, feel free to contribute it in a new PR. Otherwise I'll add a few words later today.

zsiciarz added a commit that referenced this pull request Jul 19, 2015
@zsiciarz
Copy link
Owner

FYI, I've added a paragraph about mock in bdb92a3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants