Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to Github Actions #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

richardbarran
Copy link
Contributor

See also #64. Travis-CI will no longer be free. This PR proposes a switch to Github Actions.

Notes:

  • I removed testing against Python 2.7 as it required special cases in the tests (e.g. installing a specific version of django-honeypot) and 2.7 has been deprecated for a long time, so we shouldn't be supporting it anyway, I think.
  • The existing tox file tested against django master, but the required file is no longer available to download. I simply removed this option - my thinking was that for a mature project like this one there is little need to test against the bleeding edge? But happy to change it if you think otherwise.
  • I've set badges in the README to point to my own repo (so that you can see that they're working). They'll need updating after a merge to point back to the master branch.

Also: coverage reports
I've tried in the past to get Github Actions to interface with Coveralls (for coverage reports) but without success. I'm not the only person having issues - see this very long thread opened in 2019 for an example and the current status is that it's still buggy.

I've used Codecov instead. The report for this PR is at https://app.codecov.io/gh/richardbarran/django-envelope.
If you're happy with the switch of providers you'll have to:

The test matrix is outdated, but I've left it 'as is' as much as possible - with the exception of removing Python 2.7. I'd be happy to submit a second PR with updates to test only supported versions of Django e.g. 3.2 and of Python.

@richardbarran
Copy link
Contributor Author

Addition to above: I notice that the docs has a development page that would need updating with correct links to the new CI pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant