Don't use inline scripts to render the widget #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we will function in django admin, when JQUERY_URL is set to None (because the rest of the site provides a jQuery).
Rather than using inline scripts, just apply some attributes to the widget, so we can locate it later in the DOM. This means jQuery doesn't have to be loaded before the MarkItUpWidget or markitup_editor tag is rendered on a page, all scripts can be loaded in the document foot. Fixes: zsiciarz#25
Use multiple TestCases for the widget + template tag variations rather than auto_preview permutations.
stefanor
force-pushed
the
no-inline-scripts
branch
from
e54ee44
to
f9667e6
Compare
stefanor
added a commit
to CTPUG/wafer
that referenced
this pull request
Feb 1, 2018
Now that django-markitup doesn't use inline JS any more. This was my testing commit for zsiciarz/django-markitup#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using inline scripts to configure markitup editors, just apply some attributes to the widget, so we can locate it later in the DOM.
This means jQuery doesn't have to be loaded before the MarkItUpWidget is rendered on a page, all scripts can be loaded in the document foot.
Fixes: #25