LPS-62061 URL does not redirected to site default locale for non-available i18nPath. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… icon from asset renderer
… of the old images
…chance to be null. We need another try with languageCode as languageId since we can either use languageId or languageCode in i18nPath.
…id locale, i18nLanguageId is a string with language and locale, i.e. "en_US"; 2.If we cannot get a valid locale, e.g. locale equals null, we will keep i18nLanguageId as whatever retrieved from i18Path. Thus, i18nLanguageId has no chance from a default locale.
…honest i18nLanguageId alone is able to decide: If there is a i18nLanguageId, just check whether it is group-available.
…et to test. We initialize new requests for test cases every time to avoid sharing request, which can affect testing result.
|
Forwarded to giros#26 Thank you, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Zsigmond
Please go to the forum thread to get detailed explanations.
Thanks
John.