Display and From<Schedule> for String #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support turning a
cron::Scheduleback into a string as discussed in #46. That issue spoke of ato_string()method, but this PR instead implementsFrom<Schedule> for String, which feels more Rust:y.The "pure" way to implement this would be to have the nom functions return the full string as well as the parsed result and use that to construct the Schedule objects. However, I felt that would risk complicating future refactoring and instead chose to inject the original representation into the Schedule struct by replacing an option value. A bit more hack:y, but a better separation of concerns, I think.