Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2): add messy implementation for futures ws #3

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tiagosiebler
Copy link

Excuse the mess as this is just a very rough MVP/POC to get the futures WS hooked up. Not sure I'll manage to clean it up properly, but hopefully it's helpful should you wish to adopt it in a cleaner way as the pieces are all mostly functional.

Summary:

  • ping/pong parsing/messaging needed changing, as the format is different for this ws
  • request keys needed changing as they're not camel case
  • the signature mechanism needed changing as it's slightly different
  • the parsers need changing as they're not returning the same data format

Feel free to close this if you don't need this PR, I just wanted it noted down if it's a time saver in future! Thanks for the guidance you gave!

@zsojma
Copy link
Owner

zsojma commented Jun 14, 2021

Hi @tiagosiebler, thanks for the PR. It will definitely save me some time in the future! I really appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants