Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate data collection from reporting #21

Merged
merged 35 commits into from
Jul 6, 2017
Merged

separate data collection from reporting #21

merged 35 commits into from
Jul 6, 2017

Conversation

zsoldosp
Copy link
Owner

the combining the output from multiple runs (e.g.: parallel execution) should be in a different MR, as it is already large enough

@zsoldosp
lay out plan/design how to separate reporting from data collection
f7c443a
@zsoldosp
bumpversion
56393f4
@zsoldosp
don't forget to inform users about the changes
de04c86
@zsoldosp
perf. improvement reminder note
115f459
@zsoldosp
pre-step: need to have all collectors provide sample events
4f10925
@zsoldosp
introduce <collector_cls>.get_sample_results method
46fbc9e 
to make it easier to test reporting, serialization, etc. with
'real' data easier
@zsoldosp
document how the plugin_cls.get_sample_results can be converted to py…
6398196 
…test fixtures
@zsoldosp
get better id in case of test failure
40b01ef
@zsoldosp
hide infrastrucure behind fixture, so test are easier to write - just…
164f94f 
… by declaring a feautre
@zsoldosp
add tmpfilepath fixture
20d3c4e
@zsoldosp
flake8
262a561
@zsoldosp
basic pickle serialization added
48bdd15
@zsoldosp
bugfix: need to serialize the context too
ec5a6e8
@zsoldosp
convert WithId from type to helper method, as then it's easy to pickle
eaeba53
@zsoldosp
for more prod-proof test, convert input to writer to be results_colle…
6f2590e 
…cted signal based
@zsoldosp
fix variable naming
2b7d7e2
@zsoldosp
convert existing test to also use signals for data input
07fafe4
@zsoldosp
shouldn't try to de-pickle empty input
fbab6d1
@zsoldosp
regression test: writer should only write when end is called
27e7615
@zsoldosp
only open the file just before starting the write
091621c
@zsoldosp
don't forget to disconnect the results_collected signal when flushing…
a8c0d31 
… to disk
@zsoldosp
introducing results_read signal - that is what's fired by read_all
62abd71
@zsoldosp
for test runner, collected results are serialized out to settings.DJP…
a03e590 
…T_DATAFILE_PATH
@zsoldosp
braindump of todos added
a9c1c2e
@zsoldosp
introduce serializer.get_datafile_path
796c43a
@zsoldosp
flake8 fixes
d1708f0
@zsoldosp
safepoint commit: changed to results_read signal for worstreport
4a4554b 
only test_has_worst_test_method_in_the_report is failing
@zsoldosp
integrate reader/writer into the existing test setup, all tests passing
54b2eb1
@zsoldosp
add some release notes
5a2f737
@zsoldosp
prefactoring: convert worst items report to management command
f09b719
@zsoldosp zsoldosp mentioned this pull request Jun 28, 2017
Open
kairichard
kairichard reviewed Jul 6, 2017
View reviewed changes
tests/testapp/tests/test_serialization.py Outdated
@@ -46,6 +46,12 @@ def test_writer_writes_collected_results_fired_between_statt_stop(tmpfilepath):
reader = serializer.Reader(tmpfilepath)
deserialized = reader.read_all()
assert deserialized == [(WithId('after start'), [2], {'after': 'start'})]
writer.end() # dump daa again
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/daa/data/

@kairichard
Copy link
Contributor

Looks good to me.

@kairichard kairichard assigned zsoldosp and unassigned kairichard Jul 6, 2017
@zsoldosp zsoldosp assigned kairichard and unassigned zsoldosp Jul 6, 2017
@kairichard kairichard merged commit 05d7b01 into master Jul 6, 2017
@zsoldosp
Copy link
Owner Author

@kairichard this has been merged, yet https://pypi.python.org/pypi/django-performance-testing/ still only has the previous version (0.6.1). What happened w/ the release train?

@zsoldosp zsoldosp deleted the pz-separate-data-collection-from-reporting branch July 10, 2017 10:04
@kairichard
Copy link
Contributor

@zsoldosp There seems to be a problem with pusblishing the package ->

HTTPError: 410 Client Error: Gone (This API has been deprecated and removed from legacy PyPI in favor of using the APIs available in the new PyPI.org implementation of PyPI (located at https://pypi.org/). For more information about migrating your use of this API to PyPI.org, please see https://packaging.python.org/guides/migrating-to-pypi-org/#uploading. For more information about the sunsetting of this API, please see https://mail.python.org/pipermail/distutils-sig/2017-June/030766.html) for url: https://pypi.python.org/pypi/

@kairichard
Copy link
Contributor

@zsoldosp Will look into that ASAP

@kairichard
Copy link
Contributor

@zsoldosp Here is the reason the pipeline failed -> https://mail.python.org/pipermail/distutils-sig/2017-June/030766.html

@kairichard
Copy link
Contributor

@zsoldosp the problem is found and fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairichard kairichard kairichard left review comments

Assignees

@kairichard kairichard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zsoldosp @kairichard