-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use indexOf instead of String.prototype.includes to support IE #112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 148 148
=====================================
Hits 148 148
Continue to review full report at Codecov.
|
Is this repository still being maintained? :) |
Looks like the maintainer is recovering from an accident: nuxt/nuxt#328 . I hope he's doing well! |
Well spotted @ibrahima, thank you. Best wishes for a good recovery @declandewet! |
Hi! I joined this project as a maintainer today. I'm not too sure about this change because while In a scenario where you add a polyfill for If So it's not only about changing the library code to support an old browser, but about who's responsible for making the code work in the older browser. What's your take on this? Would you be willing to use a polyfill? Instead of this change I'd add a note about ES features that should be polyfilled. |
That sounds reasonable, @fatfisz. I agree with your statement, it's just the unfortunate few of us who have to cater for the remaining 3-4% on IE :) I've already solved this with a polyfill on my side, but a note about older browser support / polyfills in the readme would be great 👍 Thanks for your comment, I'll close this for now. |
I couldn't agree more with the "unfortunate" bit, at my work we also support IE 11 and there's a dedicated file with polyfills - I had to add another one to the list no further than yesterday... I'll add a note about used features soon, thanks for your patience 🙂 |
When run in IE the code throws an error since String.prototype.includes does not exist in IE, and it is not transpiled by babel either. Can we switch to use the cross browser compatible
indexOf()
instead?