-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix InlineArrayTransformer adding extra newlines when maintaining indentation [WIP] #114
Fix InlineArrayTransformer adding extra newlines when maintaining indentation [WIP] #114
Conversation
The latter test tests behavior that I think should be correct, but it fails because it is not the current behavior.
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 23 23
Lines 149 149
=====================================
Hits 149 149
Continue to review full report at Codecov.
|
Hi, what a good catch! Answering your question from #113: I think using a negation in this case is just fine because it should be future-proof. |
@ibrahima I don't have permissions to re-run the build, but OTOH you could add a commit that adds you to contributors in |
I just pushed a merge commit; I feel weird adding myself to contributors in package.json since it's a small patch, and not all the existing contributors on Github are in there. But anyway, CI should run again now. |
If that's how you feel, then ok. If you change your mind though, don't hesitate to get back to us - you actually found the root cause and spent some time on fixing the problem, which is much more than most people do. If this is not worthy a mention in |
Released in v1.5.0! |
Thanks! |
The latter test tests behavior that I think should be correct, but it
fails because it is not the current behavior.