Fix migration script by an ugly hack and improve test #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite good intentions previous version of migration didn't and won't work. Also, unit test wasn't good enough to catch this issue. Therefore, I've applied an ugly hack, because I don't know how else to solve this(no, I'm not going to create __init__.py anywhere just because of this) and written new unit test(there were couple versions at couple different places as debugging was moving from one place to another) which of course was failing with Traceback observed "in production". Issue was a minor one since it could be solved by temporarily importing rss2irc where needed.
zstyblik
force-pushed
the
fix_dataclass
branch
from
e82484b
to
88e6fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite good intentions previous version of migration didn't and won't
work. Also, unit test wasn't good enough to catch this issue.
Therefore, I've applied an ugly hack, because I don't know how else to
solve this(no, I'm not going to create
__init__.pyanywhere just becauseof this) and written new unit test(there were couple versions at couple
different places as debugging was moving from one place to another)
which of course was failing with Traceback observed "in production".
Issue was a minor one since it could be solved by temporarily importing
rss2irc where needed.