Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling of content-type with charset included #18

Closed
wants to merge 1 commit into from
Closed

handling of content-type with charset included #18

wants to merge 1 commit into from

Conversation

mpenet
Copy link
Contributor

@mpenet mpenet commented Apr 13, 2011

Hello,

I noticed Firefox 3+ adds charset to XHR requests when sending application/x-www-form-urlencoded requests.
Checking the rfc about it I read it is normal and can also happen with any other content-type.

see: http://www.w3.org/TR/XMLHttpRequest/

I just changed content-type checks using "=" to "contains." .

@ztellman
Copy link
Collaborator

A more robust fix is to use the :content-type value on the request, rather than the value in the headers. I've checked such a fix in.

@ztellman ztellman closed this Apr 20, 2011
@mpenet
Copy link
Contributor Author

mpenet commented Apr 20, 2011

It makes more sense yes, thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants