We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is also causing macroexpand-all to fail with NPE (handler fn is nil) for all forms containing var forms:
macroexpand-all
user=> (riddley.walk/macroexpand-all '(var riddley.walk/macroexpand-all)) NullPointerException riddley.walk/walk-exprs/fn--1323 (walk.clj:202)
This was introduced in ced3fa5 which also adds a test that relies on the fact that handler fn gets called even though predicate is constantly false.
I wasn't sure how to fix this. Do you also expect macroexpand-all to return var values instead of var forms?
The text was updated successfully, but these errors were encountered:
I just need to add a predicate check to that condition, I think.
Sorry, something went wrong.
Only walk var forms when the predicate passes
02ec516
fixes ztellman#12
92ed29b
Successfully merging a pull request may close this issue.
This is also causing
macroexpand-all
to fail with NPE (handler fn is nil) for all forms containing var forms:This was introduced in ced3fa5 which also adds a test that relies on the fact that handler fn gets called even though predicate is constantly false.
I wasn't sure how to fix this. Do you also expect
macroexpand-all
to return var values instead of var forms?The text was updated successfully, but these errors were encountered: