Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walk-exprs handler fn is called for var forms regardless of predicate #12

Closed
immoh opened this issue May 28, 2014 · 1 comment · Fixed by #14
Closed

walk-exprs handler fn is called for var forms regardless of predicate #12

immoh opened this issue May 28, 2014 · 1 comment · Fixed by #14

Comments

@immoh
Copy link
Contributor

immoh commented May 28, 2014

This is also causing macroexpand-all to fail with NPE (handler fn is nil) for all forms containing var forms:

user=> (riddley.walk/macroexpand-all '(var riddley.walk/macroexpand-all))
NullPointerException   riddley.walk/walk-exprs/fn--1323 (walk.clj:202)

This was introduced in ced3fa5 which also adds a test that relies on the fact that handler fn gets called even though predicate is constantly false.

I wasn't sure how to fix this. Do you also expect macroexpand-all to return var values instead of var forms?

@ztellman
Copy link
Owner

ztellman commented Jun 8, 2014

I just need to add a predicate check to that condition, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants