Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat with ReScript v10 #372

Merged
merged 1 commit into from
Jul 6, 2022
Merged

compat with ReScript v10 #372

merged 1 commit into from
Jul 6, 2022

Conversation

zth
Copy link
Owner

@zth zth commented Jul 6, 2022

Fixes #373

The issue was that the ReScript v10 parser inserts (internal) attributes at positions that ppxlib does not consider valid OCaml.

Solution short/mid term: use forked ppxlib that has been patched to ignore the invalid attributes.
Solution long term: Move off of ppxlib (and other OCaml-specific libraries completely where ReScript might break compat).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks on ReScript v10
1 participant