Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@babel/types should be listed in dependencies instead of devDependencies #127

Closed
heiseshandian opened this issue Jun 2, 2022 · 1 comment

Comments

@heiseshandian
Copy link

Currently, in src/plugins/babel/visitor.ts, we directly use the utils imported from @babel/types/lib/builders/generated, which means @babel/types/lib/builders/generated is not only needed during development, we should put it under dependencies instead of devDependencies.

import {
  jsxAttribute,
  jsxIdentifier,
  stringLiteral,
} from '@babel/types/lib/builders/generated'
//...

const lineAttr: JSXAttribute | null = isNil(line)
    ? null
    : jsxAttribute(
      jsxIdentifier('data-inspector-line'),
      stringLiteral(line.toString()),
    )
@zthxxx zthxxx closed this as completed in 4aa7072 Jun 14, 2022
@zthxxx
Copy link
Owner

zthxxx commented Jun 14, 2022

@heiseshandian Sorry for wait, I have not noticed this issue's notification, now it fixed in react-dev-inspector@1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants