Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Check my buff periodically #5

Closed
ztkmkoo opened this issue Dec 12, 2020 · 3 comments · Fixed by #6
Closed

[Feature] Check my buff periodically #5

ztkmkoo opened this issue Dec 12, 2020 · 3 comments · Fixed by #6
Assignees
@ztkmkoo
Labels
enhancement New feature or request

Comments

@ztkmkoo
Copy link
Owner

ztkmkoo commented Dec 12, 2020

Start an interval timer (5 min) check the buff.

  • If remaining minutes is less than 10 min, make a print to alert to user.
@ztkmkoo ztkmkoo added the enhancement New feature or request label Dec 12, 2020
@ztkmkoo ztkmkoo self-assigned this Dec 12, 2020
@ztkmkoo
Copy link
Owner Author

ztkmkoo commented Dec 12, 2020

ref https://wow.gamepedia.com/API_C_Timer.NewTicker

@ztkmkoo
Copy link
Owner Author

ztkmkoo commented Dec 12, 2020

ref https://wow.gamepedia.com/API_C_Timer.NewTicker

There may be some concurrency issues.

@ztkmkoo
Copy link
Owner Author

ztkmkoo commented Dec 13, 2020

Instead of using OnUpdate Event
https://www.wowinterface.com/forums/showthread.php?t=48370

ztkmkoo added a commit that referenced this issue Dec 13, 2020
@ztkmkoo
[#5] Check my buff periodically
657a756 
- add OnUpdate handler
ztkmkoo added a commit that referenced this issue Dec 13, 2020
@ztkmkoo
[#5] Check my buff periodically
dd21482 
- reg buff onload
- check every 60 sec, print if buff remaining minutes is less than 60 min
ztkmkoo added a commit that referenced this issue Dec 13, 2020
@ztkmkoo
[#5] Check my buff periodically
9473b67 
- remove unused function
ztkmkoo added a commit that referenced this issue Dec 13, 2020
@ztkmkoo
[#5] Check my buff periodically
ffdffd1 
- remove unused log
- improve remaining minutes text
ztkmkoo added a commit that referenced this issue Dec 13, 2020
@ztkmkoo
[#5] Check my buff periodically
889d179
ztkmkoo added a commit that referenced this issue Dec 13, 2020
@ztkmkoo
[#5] Check my buff periodically
c9b7035
@ztkmkoo ztkmkoo mentioned this issue Dec 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ztkmkoo ztkmkoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/5 interval timer ztkmkoo/show-my-time
1 participant
@ztkmkoo