Fix the composer provide rules #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package does not provide the code of the psr interface packages. It provides implementations of the interfaces and so should provide the virtual packages representing implementations of the interface. Providing the wrong package while also requiring it creates issues with Composer 2, because the solver will consider that installing the psr packages is not necessary as they are already provided.
|
Thanks @stof |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package does not provide the code of the psr interface packages. It provides implementations of the interfaces and so should provide the virtual packages representing implementations of the interface.
Providing the wrong package while also requiring it creates issues with Composer 2, because the solver will consider that installing the psr packages is not necessary as they are already provided.
Refs composer/composer#9316 (not the same package than the one mentioned in the bug report, but same issue)