Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sync support - Replicator/Aggregator #24

Merged
merged 6 commits into from Feb 23, 2017
Merged

Add sync support - Replicator/Aggregator #24

merged 6 commits into from Feb 23, 2017

Conversation

varet80
Copy link
Contributor

@varet80 varet80 commented Feb 23, 2017

I made some additions to the repository, in order to support dovecot replication.

  • Added a new conf.d f/15-replication.conf template which supports new service declarations
    • aggregator
    • replicator
    • config

Also added two new attributes for the replication:

  • doveadm_port
  • doveadm_secret

@varet80
Service: Add support for Dovecot Replication
4a27e61 
- Add new template conf.d/15-replication.conf
  - New Services supported: doveadm, replicator, aggregator, config
  - two new attributes:
    - doveadm_port: used for the replication port setting
    - doveadm_password: used for the replication secret
@varet80
Replication: Remove doveadm (duplicate declaration)
81da79b
@zuazo
Copy link
Owner

zuazo commented Feb 23, 2017

Thanks for your contribution, @varET! 😄

Please, could you add a small description of those new attributes and services to the README / metadata? The node['dovecot']['services'] documentation also needs to be updated to include the new services.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 81da79b on varet:replication into 707ad3e on zuazo:master.

@varet80
Copy link
Contributor Author

varet80 commented Feb 23, 2017

Hey Zuazo,

my bad, going to do it asap ! 👍

@varet80
Copy link
Contributor Author

varet80 commented Feb 23, 2017

wish i didn't forget something

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2839381 on varet:replication into 707ad3e on zuazo:master.

zuazo
zuazo requested changes Feb 23, 2017
View reviewed changes
Copy link
Owner

@zuazo zuazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Thanks for your quick response 😉

I added two comments about two minor details of little importance. As soon as you change them, I will merge it.

README.md Outdated
http://www.apache.org/licenses/LICENSE-2.0

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, do not remove these lines with spaces in the license section. They may seem accidental, but they are there to prevent some buggy markdown viewers from breaking the box that contains the license.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put it back, it is my editor (cleaning white spaces)

README.md
@@ -321,6 +321,18 @@ Also used by LMTP.
| `node['dovecot']['conf']['lda_mailbox_autocreate']` | *nil* | Should saving a mail to a nonexistent mailbox automatically create it?
| `node['dovecot']['conf']['lda_mailbox_autosubscribe']` | *nil* | Should automatically created mailboxes be also automatically subscribed?

## Replication Specific Attributes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new section needs to be added to the Table of Contents.

@varet80
Documentation
e9d6e94 
README.md
- Re-Add whitespaces (due to bug)
- add missing entry on Table of contents
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e9d6e94 on varet:replication into 707ad3e on zuazo:master.

zuazo
zuazo approved these changes Feb 23, 2017
View reviewed changes
Copy link
Owner

@zuazo zuazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@zuazo zuazo merged commit 5da5eba into zuazo:master Feb 23, 2017
@varet80
Copy link
Contributor Author

varet80 commented Feb 23, 2017 via email •
edited by zuazo

@zuazo
Copy link
Owner

zuazo commented Feb 23, 2017 •
edited

Yes, I'm going to release 3.1.0 soon. Give me a couple of days.

@zuazo
Copy link
Owner

zuazo commented Feb 27, 2017

Released in 3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuazo zuazo zuazo approved these changes

Assignees
No one assigned
Labels
Status: Pending Contributor Response Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@varet80 @zuazo @coveralls