Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth-definitions below ldap are a hash, not an array #6

Merged
merged 1 commit into from Mar 7, 2014
Merged

Auth-definitions below ldap are a hash, not an array #6

merged 1 commit into from Mar 7, 2014

Conversation

kampfschlaefer
Copy link
Contributor

While using this cookbook to set up a dovecot authenticating against an AD I wondered the following didn't make it install dovecot-ldap (I like using symbols in my recipes):

node.default[:dovecot][:auth][:ldap][:passdb][:args] = '/etc/dovecot/dovecot-ldap.conf.ext'
node.default[:dovecot][:auth][:ldap][:userdb][:args] = '/etc/dovecot/dovecot-ldap.conf.ext'

This patch fixes this.

The patch could even be simplified by writing

only_if node['dovecot']['auth'].fetch('ldap', {}).length > 0

zuazo added a commit that referenced this pull request Mar 7, 2014
@zuazo
Merge pull request #6 from bcs-de/fix_ldap_auth
4532582 
Auth-definitions below ldap are a hash, not an array
@zuazo zuazo merged commit 4532582 into zuazo:master Mar 7, 2014
@zuazo
Copy link
Owner

zuazo commented Mar 7, 2014

Nice PR. Thanks for the fix 😄

@zuazo
Copy link
Owner

zuazo commented Mar 13, 2014

Released in version 0.3.0.

@kampfschlaefer kampfschlaefer deleted the fix_ldap_auth branch March 13, 2014 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampfschlaefer @zuazo