Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow newer versions of yum-epel cookbook #2

Closed
wants to merge 1 commit into from
Closed

allow newer versions of yum-epel cookbook #2

wants to merge 1 commit into from

Conversation

mburns
Copy link
Contributor

@mburns mburns commented Mar 7, 2018

Description

Allow newer versions (0.5.x - 3.x.y, inclusive) of the yum-epel cookbook, to support nodes using newer versions of Chef that don't support the most recent version supported by the cookbook.

yum-epel is on v3.1.0 and this cookbook shouldn't have any breaking changes by allowing newer versions as dependencies, given our simple use case.

Contribution Check List

  • All tests pass.
  • New functionality includes testing.
  • New functionality has been documented in the README and metadata if applicable.

See CONTRIBUTING.md.

@coveralls
Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 07a3584 on mburns:patch-1 into 40d6f2f on zuazo:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b51b5ef on mburns:patch-1 into 40d6f2f on zuazo:master.

@mburns
Copy link
Contributor Author

mburns commented Mar 7, 2018

failed test appears unrelated to code changed:

E: Failed to fetch http://archive.ubuntu.com/ubuntu/dists/yakkety-backports/multiverse/binary-amd64/Packages  404  Not Found [IP: 91.189.88.149 80]
E: Some index files failed to download. They have been ignored, or old ones used instead.
STDERR: The command '/bin/sh -c apt-get update' returned a non-zero code: 100

Copy link
Owner

@zuazo zuazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 😃

I'm not sure why you removed the ruby pessimistic operator. If you could, please, clarify the reason for that.

metadata.rb Outdated
@@ -46,7 +46,7 @@
supports 'scientific'
supports 'ubuntu'

depends 'yum-epel', '~> 0.5'
depends 'yum-epel', '> 0.5'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we update the version number, I think we should conserve the pessimistic operator, shouldn't we?

@mburns
Copy link
Contributor Author

mburns commented Mar 7, 2018

Hi @zuazo!

I've tweaked the logic to have an upper limit to the valid versions (up to and including the current ~> 3.1), so that we won't pull in a 4.x version in case they radically change behavior. Good suggestion.

Because of the simple use of yum-epel, all versions released (assuming your platform and cookbook dependency graph allows) appear to work for this cookbook's purposes.

Why? For complex run_lists or nodes moving to Chef 13+, it is nice to not be pinned to the old dependency version 0.5 from ~3.5 years ago. 0.7.

@nicutor
Copy link

nicutor commented Feb 19, 2019

Hi, I would like to use this cookbook but I can't because of this little thing that was not fixed from about 1 year now.. There was removed only a char to allow upper versions to be got, its that hard to make that change and release a new version?

@mburns
Copy link
Contributor Author

mburns commented Sep 18, 2019

@zuazo let's merge or close this PR, please. Cheers!

@mburns mburns requested a review from zuazo September 21, 2019 22:46
@mburns mburns closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants