New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow newer versions of yum-epel cookbook #2
Conversation
failed test appears unrelated to code changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! 😃
I'm not sure why you removed the ruby pessimistic operator. If you could, please, clarify the reason for that.
metadata.rb
Outdated
@@ -46,7 +46,7 @@ | |||
supports 'scientific' | |||
supports 'ubuntu' | |||
|
|||
depends 'yum-epel', '~> 0.5' | |||
depends 'yum-epel', '> 0.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we update the version number, I think we should conserve the pessimistic operator, shouldn't we?
Hi @zuazo! I've tweaked the logic to have an upper limit to the valid versions (up to and including the current Because of the simple use of Why? For complex run_lists or nodes moving to Chef 13+, it is nice to not be pinned to the old dependency version |
Hi, I would like to use this cookbook but I can't because of this little thing that was not fixed from about 1 year now.. There was removed only a char to allow upper versions to be got, its that hard to make that change and release a new version? |
@zuazo let's merge or close this PR, please. Cheers! |
Description
Allow newer versions (
0.5.x - 3.x.y
, inclusive) of theyum-epel
cookbook, to support nodes using newer versions of Chef that don't support the most recent version supported by the cookbook.yum-epel is on
v3.1.0
and this cookbook shouldn't have any breaking changes by allowing newer versions as dependencies, given our simple use case.Contribution Check List
See CONTRIBUTING.md.