Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode #105

Open
zufuliu opened this issue Feb 27, 2019 · 17 comments
Open

Dark Mode #105

zufuliu opened this issue Feb 27, 2019 · 17 comments

Comments

@zufuliu
Copy link
Owner

zufuliu commented Feb 27, 2019

2nd default scheme now configured as base style for dark mode (commit f587369).

Built-in lexer styles still not configured for dark mode, some color (red, blue, etc.) is very ugly in dark mode.
dark-python

@testinsovr
Copy link

testinsovr commented Feb 27, 2019

Basically, it would be nice if the color caret is the opposite of the background color.
Even with various color background settings, the carats will be visible.

and, some opinion.
issue - Batch - label
'fore: # C80000; back: # F4F4F4; eolfilled '
It would be nice to change it to the default value.

@testinsovr
Copy link

'Set built-in style for Batch label to eolfilled.'
Thank you very much.

@zufuliu
Copy link
Owner Author

zufuliu commented Apr 8, 2019

I think dark mode / theme is ready, I added a new screenshot for v4.19.04.

v4.19.04

Menu, toolbar and statusbar requires complicate custom drawing for dark mode, are not implemented.

@zufuliu
Copy link
Owner Author

zufuliu commented Jun 10, 2019

The white area above auto-completion box on win10 (above screenshot by v4.19.04) was removed in v4.19.06.
Related discussion can be found at https://sourceforge.net/p/scintilla/feature-requests/1284/.

v4.19.06

@jzhao2007
Copy link

Hi,zu
did you get this one patched for the new version? I am running 4.19.06 r2148 now, cursor is still invisible in the dark mode

@zufuliu
Copy link
Owner Author

zufuliu commented Dec 16, 2019

@jzhao2007 can you try v4.19.12.r2604 and replace Notepad2 DarkTheme.ini with the one in zip.

@maboroshin
Copy link
Contributor

maboroshin commented Jan 21, 2020

Hi! I created 18 color themes. maboroshin/Notepad2ColorTheme

My recommendations: In order, Solarized Dark, Iceburg (Dark), Solarized Light. My tweaks are now visible in probably all languages.
In Solarized (Notepad2_Solarized.ini), color scheme 1 is light and color scheme 2 is dark. But some languages in this light theme are a bit darker.

@zufuliu
Copy link
Owner Author

zufuliu commented Jan 30, 2020

Unfortunately, Notepad2 doesn't auto discover theme files.

@maboroshin
Copy link
Contributor

With the import feature, I can easily use my favorite light and dark!

@zufuliu
Copy link
Owner Author

zufuliu commented May 20, 2020

There are code to detect system dark mode on Win 10:

https://sourceforge.net/p/scintilla/scite/ci/09b21fe9d954ba1b350289fdbe7b16d59f7134ac/

HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Themes\Personalize
    AppsUseLightTheme           REG_DWORD
    SystemUsesLightTheme        REG_DWORD
HIGHCONTRAST info{};
info.cbSize = sizeof(HIGHCONTRAST)
SystemParametersInfo(SPI_GETHIGHCONTRAST, 0, &info, 0);
info.dwFlags & HCF_HIGHCONTRASTON;

@maboroshin
Copy link
Contributor

This is simple.

If the system is in dark mode when Notepad2's auto-detection setting is on, apply the dark theme.
New menu: Style Theme -> Auto Detect (or System Color ... etc)

Apps such as the following are already auto-detected.

@zufuliu
Copy link
Owner Author

zufuliu commented Jun 2, 2020

It can be added later. by the way, you can use DarkTheme.ini (in Notepad2 section in Notepad2.ini) to set custom theme file path, without import.

[Notepad2]
;Notepad2.ini=%LOCALAPPDATA%\Notepad2\Notepad2.ini
;DarkTheme.ini=%LOCALAPPDATA%\Notepad2\Notepad2 DarkTheme.ini
[Settings]
SettingsVersion=1

@ejm554
Copy link

ejm554 commented Oct 29, 2022

Question from occasional user (but still a fan!) of Notepad2.

How do you turn Dark Mode on? Is there a setting in the GUI? Do I need to configure the .ini or other files?

@zufuliu
Copy link
Owner Author

zufuliu commented Oct 29, 2022

Hi @ejm554, the settings menu is Scheme -> Style Theme.

@ejm554
Copy link

ejm554 commented Nov 19, 2022

Thanks, but still struggling to find it. Is it in one of the following menus/windows? Or am I missing something? I also tried turning on the 2nd default scheme, as noted in the original post in this issue thread, but I didn't notice any changes.

If you could provide more explicit steps, maybe with screenshots, that might help! FYI, I'm running 4.2.25 r998.

image

image

@zufuliu
Copy link
Owner Author

zufuliu commented Nov 19, 2022

Hi @ejm554 please download latest release from https://github.com/zufuliu/notepad2/releases
Dark

@zufuliu zufuliu added the ui label Jan 7, 2023
@Spode
Copy link

Spode commented Feb 24, 2023

Hey all. Could full dark mode support be added where the entire UI can be made dark (preferably based on OS setting like previously mentioned in the thread)? I am a big fan of this fork of Notepad2 with all its features, but during night time I reluctantly use alternatives due to this.

Notepad3 implemented it using https://github.com/ysc3839/win32-darkmode/

Notepad3 using Windows 11 Dark theme
np3dark

Notepad3 using Windows 11 Default theme
np3light

Notepad2 using Windows 11 Dark theme
np2dark

Notepad2 using Windows 11 Dark theme but Dark Style manually enabled
np2darksyntax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants