Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block caret position #118

Closed
zufuliu opened this issue Jun 18, 2019 · 5 comments
Closed

Block caret position #118

zufuliu opened this issue Jun 18, 2019 · 5 comments
Labels

Comments

@zufuliu
Copy link
Owner

zufuliu commented Jun 18, 2019

See https://sourceforge.net/p/scintilla/bugs/1924/ and https://sourceforge.net/p/scintilla/bugs/2106/

@zufuliu
Copy link
Owner Author

zufuliu commented Jun 18, 2019

Hi @bluenlive, may I bother you again about block caret.

Bug 1924 will add a new option for block caret's position: within selection (current) or outside selection (CARETSTYLE_BLOCK_EXCLUSIVE)? which is better to be default?

For Bug 2106, should the bar/underline caret in OVR mode been treated same as block caret in INS mode (i.e. draw under last character within selection,see https://sourceforge.net/p/scintilla/bugs/2106/#cecd/d7e7)? or it should always draw block caret in both mode when using Korean IME?

@bluenlive
Copy link

@zufuliu Sorry for late answer.

  1. In my opinion, current style(caret is within selection) is more natural.

  2. In Korean environment, drawing block caret in both (OVR/INS) mode when using IME is better.

Thank you always.

@zufuliu
Copy link
Owner Author

zufuliu commented Jun 21, 2019

@bluenlive Thanks.

The equivalent for drawing block caret in both mode can be enabled with "Block (OVR Mode)" and "Block (INS Mode)".

caret-style

@bluenlive
Copy link

@zufuliu Thank you very much! You are always my hero!

@zufuliu
Copy link
Owner Author

zufuliu commented Jun 30, 2019

Fixed in Scintilla.

@zufuliu zufuliu closed this as completed Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants