Modify Lines : Skip Blank Lines

[meteorquake]

The "Modify Lines" is very useful, with its prefixing and suffixing.
Can I recommend a tickbox "Skip blank lines" as quite often you're only wanting to modify lines with content. I suppose this would be best as truly blank lines rather than also lines that are whitespace but someone may comment it would be good to include those too.
Or it could be expressed as "Include Blank Lines" with it defaulted as ticked.
I don't think it would burden the box's appearance.
David

[zufuliu]

Added "Skip empty lines" option in 078a14a. skip empty line is easy to implement than skip blank line (line that is empty or contains only whitespaces).

[meteorquake]

That looks great - and fantastic turnover time as ever (I will have to start a stopwatch next time!) :)

You may want to omit the trailing '.' on each option there as an aesthetic improvement? for example the Find dialog lacks them - maybe there are some other boxes similarly.

[meteorquake]

As an extra thought, it may be the 6 line number options there can be replaced by 2 boxes, one for the start number, one for the formatting, the reference to which then can always be $(N)

[zufuliu]

it may be the 6 line number options there can be replaced by 2 boxes

Use different letters would simplify parsing (after e0ecc0f):

notepad2/src/Edit.c

Lines 2931 to 2937 in e0ecc0f

	const uint8_t substitution = *p;
	if (substitution == EditModifyLinesSubstitution_LineNumber) {
	lineCount = iLineEnd + 1;
	} else {
	number = substitution == EditModifyLinesSubstitution_NumberOne;
	lineCount = iLineEnd - iLineStart + number;
	}