Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating in fr_FR (French) #567

Open
VoilierBleu opened this issue Dec 4, 2022 · 26 comments
Open

Translating in fr_FR (French) #567

VoilierBleu opened this issue Dec 4, 2022 · 26 comments
Labels
✅enhancement 🌐i18n Localization/Internationalization

Comments

@VoilierBleu
Copy link
Contributor

How to translate the notepad2 in french ?

@zufuliu
Copy link
Owner

zufuliu commented Dec 4, 2022

Here is out-dated document https://github.com/zufuliu/notepad2/wiki/Localization

@zufuliu zufuliu added ✅enhancement 🌐i18n Localization/Internationalization labels Dec 4, 2022
@zufuliu
Copy link
Owner

zufuliu commented Dec 7, 2022

@VoilierBleu If you are ready on translating, I can add rc files in locale\fr-FR folder.

@VoilierBleu
Copy link
Contributor Author

@zufuliu : OK, give me the link ?

@zufuliu
Copy link
Owner

zufuliu commented Dec 7, 2022

@VoilierBleu resource files added by 6afcad5, in https://github.com/zufuliu/notepad2/tree/main/locale/fr-FR folder.

@VoilierBleu
Copy link
Contributor Author

@zufuliu : To be sure, sentence with an & and a \t should be translated as

Source : "As UTF-&8\tShift+F8"
Target : "En UTF-8\tShift+F8" or "En UTF-&8\tShift+F8" ?

I don't get the interest of the & (the \t is a special char for tab, that, it's ok, i've got it).

@zufuliu
Copy link
Owner

zufuliu commented Dec 7, 2022

Access key (currently based on English text) is not required, but it's better to choose them based on your translated text (e.g. Italian translation does this).

\t need to be retained, it's used to split menu text and the shortcut. you can change shortcuts and make them easily accessible on French keyboard.

@VoilierBleu
Copy link
Contributor Author

OK, i got it, when you press Alt one time and look at the menu in Notepad2, the underline of key appear and you got them :

image

@VoilierBleu
Copy link
Contributor Author

I've done 1/3 of the works. They are a lot of lines to translate and i need to learn how to recompile it to test it. Don't expect the final result before the end of 2022 ^^.

@zufuliu
Copy link
Owner

zufuliu commented Jan 30, 2023

@VoilierBleu any news on the translating?

@VoilierBleu
Copy link
Contributor Author

Hi Zu. It's around 90% Please find the version attached in preview.
translation.vb.txt

@zufuliu
Copy link
Owner

zufuliu commented Jan 30, 2023

You can make a pull request for the translated rc file, and continue translating remaining text.

@VoilierBleu
Copy link
Contributor Author

Like that : #604 ?

@zufuliu
Copy link
Owner

zufuliu commented Jan 30, 2023

Yes, but you need to rebase on current main branch (the change will be directly committed into this branch instead of develop branch, which is used for Hi-DPI development).

@VoilierBleu
Copy link
Contributor Author

I've updated the pull request with the full translation. Now i need to test a complied version of it.

@zufuliu
Copy link
Owner

zufuliu commented Jan 31, 2023

Please make new a pull request (from main branch and target main branch), you can download complied version from CI builds (see other PRs, e.g. https://github.com/zufuliu/notepad2/actions/runs/4044198220),

@VoilierBleu
Copy link
Contributor Author

I've tried to upload the notepad2.rc file directly into https://github.com/zufuliu/notepad2/upload/main/locale/fr-FR but i don't have the right for, sorry :

" Uploads are disabled. File uploads require push access to this repository. "

@VoilierBleu
Copy link
Contributor Author

Sorry i don't understand at all how it's work, it's fucking esoteric for me.

when i'm there (https://github.com/zufuliu/notepad2/pulls), the "New pull request" button is there, if i click on it, it just propose me two base to compare and the button is desactivated, it's marled "Compare and review just about anything".

Github is a piece of shit.

@zufuliu
Copy link
Owner

zufuliu commented Jan 31, 2023

  1. goto https://github.com/VoilierBleu/notepad2
  2. click "Sync fork" button
  3. upload your file into https://github.com/VoilierBleu/notepad2/tree/main/locale/fr-FR
  4. then make pull request

@VoilierBleu
Copy link
Contributor Author

Thanks. Here it is : #605.

@zufuliu
Copy link
Owner

zufuliu commented Feb 1, 2023

Hi @VoilierBleu, I fixed compile errors and applied "Tools" menu changes in de3e312, there are new text needs translating or updating, see the table at #581 (comment).

@VoilierBleu
Copy link
Contributor Author

Hi @zufuliu : Where i can find the comiled version please ? I've seen the #581 but i don't understand when i must move the line exactly ?

@zufuliu
Copy link
Owner

zufuliu commented Feb 1, 2023

Where i can find the comiled version please

All CI builds after https://github.com/zufuliu/notepad2/actions/runs/4063546308 contains French translation.

move the line exactly

They were already moved in de3e312, you need to update the translating ("Tools", "Text Transliteration", and menus originally under "File -> Launch"):
image

@VoilierBleu
Copy link
Contributor Author

Ok. But it's not working (Notepad2_LLVM_x64_v4.23.01r4584) :

image

@zufuliu
Copy link
Owner

zufuliu commented Feb 1, 2023

Use MSVC 2022 and 2019 versions, all other are English only.

@VoilierBleu
Copy link
Contributor Author

I've begin to do some tests. French is more verbious than english, some windows Arn't large enougth, i need to check it first in all ways and to recorrect it.

Also, i don't find where i can download the new Notepad2.rc to update it, could you give me the link please ?

image

@zufuliu
Copy link
Owner

zufuliu commented Feb 2, 2023

The file is still inside https://github.com/zufuliu/notepad2/tree/main/locale/fr-FR

To get the file in your repo, you need to rebase your main branch, see https://sylhare.github.io/2021/04/05/Use-git-with-upstream-repository.html

git remote add upstream https://github.com/zufulliu/notepad2.git
git fetch upstream
git rebase upstream/main 

or just delete your repo and fork again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅enhancement 🌐i18n Localization/Internationalization
Projects
None yet
Development

No branches or pull requests

2 participants